mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 26199: Eliminated redundant resource accounting in the master.
Date Wed, 01 Oct 2014 23:05:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26199/#review55156
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/26199/#comment95539>

    hmmm. slave->used() doesn't really tell what is being returned here. how about calling
it slave->resources() instead. do you think that's less confusing?
    
    slave->resources() # used resources.
    
    slave->info.resources() # total resources.


- Vinod Kone


On Sept. 30, 2014, 11:30 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26199/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 11:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This avoids the need for the per-framework resource accounting in addTask, which is error
prone given it may diverge from the slave->used().
> 
> Rather, have Slave::used just return this mapping directly.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 41d91c842456b6d8e23b45be24210c966c287e24 
>   src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f 
>   src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e 
> 
> Diff: https://reviews.apache.org/r/26199/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message