mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 26245: Remove usage of <stout/preprocessor.hpp> from stout.
Date Wed, 01 Oct 2014 21:17:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26245/#review55130
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp
<https://reviews.apache.org/r/26245/#comment95499>

    note: we don't check for std::move in the configure script yet.



3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp
<https://reviews.apache.org/r/26245/#comment95501>

    i'm surprised the initializer list constructor works in g++-4.4. we also don't check for
that in the configure script.


- Dominic Hamon


On Oct. 1, 2014, 2:05 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26245/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 2:05 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> With variadic template support now required in Mesos, the preprocessor expansion technique
is no longer necessary. Remove its usage in stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 719aa964a536cf02dbd2de440157de487ec703b1

>   3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp d75f0f19f5515fafe2f3e0d4318e8ebc79ba1cfa

>   3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp 60f0c8c67317872883857a1cd8f39d6d6a45d0c1

>   3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp deb8df315dc121e8318584d09797667f7d3743e5

>   3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp ea8a13f25d72bb645842d32a91b168b67d33c3eb

>   3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp b121836112aa62c98d925d5463ef144890d96a4b

> 
> Diff: https://reviews.apache.org/r/26245/diff/
> 
> 
> Testing
> -------
> 
> `make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3`
and `clang-3.5`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message