Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72071171F0 for ; Tue, 30 Sep 2014 02:52:09 +0000 (UTC) Received: (qmail 9042 invoked by uid 500); 30 Sep 2014 02:52:09 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 8990 invoked by uid 500); 30 Sep 2014 02:52:09 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 8972 invoked by uid 99); 30 Sep 2014 02:52:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Sep 2014 02:52:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D569A1DDB3A; Tue, 30 Sep 2014 02:52:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6938732103750502670==" MIME-Version: 1.0 Subject: Re: Review Request 26159: Fixed framework logging in master.cpp. From: "Mesos ReviewBot" To: "Ben Mahler" Cc: "Mesos ReviewBot" , "Vinod Kone" , "mesos" Date: Tue, 30 Sep 2014 02:52:05 -0000 Message-ID: <20140930025205.18846.56930@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/26159/ X-Sender: "Mesos ReviewBot" References: <20140930011318.19177.68596@reviews.apache.org> In-Reply-To: <20140930011318.19177.68596@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos-git --===============6938732103750502670== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26159/#review54943 ----------------------------------------------------------- Patch looks great! Reviews applied: [26159] All tests passed. - Mesos ReviewBot On Sept. 30, 2014, 1:13 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26159/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2014, 1:13 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Like we did for slave, wanted to standardize how we log about a framework in master.cpp. Included framework.name() because I think it's more useful for debugging in a multi-framework world. > > No semantic changes. > > > Diffs > ----- > > src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f > src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e > > Diff: https://reviews.apache.org/r/26159/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > > --===============6938732103750502670==--