Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F017A11A5E for ; Mon, 22 Sep 2014 18:45:38 +0000 (UTC) Received: (qmail 32215 invoked by uid 500); 22 Sep 2014 18:45:38 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 32146 invoked by uid 500); 22 Sep 2014 18:45:38 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 32127 invoked by uid 99); 22 Sep 2014 18:45:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Sep 2014 18:45:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0905A1DD885; Mon, 22 Sep 2014 18:45:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2478690673586661723==" MIME-Version: 1.0 Subject: Re: Review Request 25549: Basic filesystem isolator for Linux. From: "Ian Downes" To: "Vinod Kone" , "Ben Mahler" , "Jie Yu" Cc: "mesos" , "Mesos ReviewBot" , "Timothy Chen" , "Ian Downes" Date: Mon, 22 Sep 2014 18:45:36 -0000 Message-ID: <20140922184536.14999.56975@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ian Downes" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/25549/ X-Sender: "Ian Downes" References: <20140915200105.7801.84043@reviews.apache.org> In-Reply-To: <20140915200105.7801.84043@reviews.apache.org> Reply-To: "Ian Downes" X-ReviewRequest-Repository: mesos-git --===============2478690673586661723== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/ ----------------------------------------------------------- (Updated Sept. 22, 2014, 11:45 a.m.) Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. Changes ------- Addressed comments. Bugs: MESOS-1586 https://issues.apache.org/jira/browse/MESOS-1586 Repository: mesos-git Description ------- Does not report usage or enforce quota but can create 'private' directories for each container which mask parts of the shared host filesystem. This review replaces https://reviews.apache.org/r/24178/ because of some file renaming. I addressed all comments from earlier reviews. Diffs (updated) ----- include/mesos/mesos.proto dea51f94d130c131421c43e7fd774ceb8941f501 src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee src/slave/containerizer/isolators/filesystem/shared.hpp PRE-CREATION src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION src/slave/containerizer/linux_launcher.cpp d5ef1d6aa762cf81a3e8384552d97fe95b9cbd95 src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c src/slave/flags.hpp 21e00212bc402674eaea73b44b3f91df477a7213 src/slave/slave.cpp 1b3dc7370a2441e4159aa5ee552b64ca5e511e96 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 Diff: https://reviews.apache.org/r/25549/diff/ Testing ------- make check # added a test Thanks, Ian Downes --===============2478690673586661723==--