Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D5AAC112A7 for ; Thu, 11 Sep 2014 05:00:24 +0000 (UTC) Received: (qmail 66674 invoked by uid 500); 11 Sep 2014 05:00:19 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 66601 invoked by uid 500); 11 Sep 2014 05:00:19 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 66588 invoked by uid 99); 11 Sep 2014 05:00:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Sep 2014 05:00:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C743C1DD641; Thu, 11 Sep 2014 05:00:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5664723720615795603==" MIME-Version: 1.0 Subject: Re: Review Request 25511: Pulled the log line in ZooKeeperTestServer::shutdownNetwork() to above the shutdown call. From: "Ben Mahler" To: "Ben Mahler" Cc: "Jiang Yan Xu" , "mesos" Date: Thu, 11 Sep 2014 05:00:17 -0000 Message-ID: <20140911050017.23929.77140@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/25511/ X-Sender: "Ben Mahler" References: <20140910180246.23929.59942@reviews.apache.org> In-Reply-To: <20140910180246.23929.59942@reviews.apache.org> Reply-To: "Ben Mahler" X-ReviewRequest-Repository: mesos-git --===============5664723720615795603== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25511/#review52999 ----------------------------------------------------------- Ship it! Ship It! - Ben Mahler On Sept. 10, 2014, 6:02 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25511/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2014, 6:02 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > - When debugging zookeeper related tests it's often more useful to know when the tests is about to shut down the ZK server to reason about the order of events. Otherwise client disconnections are often logged before this "shutdown" line and can be confusing. > > > Diffs > ----- > > src/tests/zookeeper_test_server.cpp a8c9b1cd8a546abdeb4d89a8fe9ebc3b3d577665 > > Diff: https://reviews.apache.org/r/25511/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > > --===============5664723720615795603==--