mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 26090: PortMappingIsolator: added support to include RTT and RTTvar in the statistics.
Date Mon, 29 Sep 2014 17:25:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26090/#review54828
-----------------------------------------------------------


Can you add a test that (at least) confirms the RTT values are non-zero?


include/mesos/mesos.proto
<https://reviews.apache.org/r/26090/#comment95121>

    Explain (expand) what RTT is, where it's sourced from and what it means?



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/26090/#comment95126>

    All this output to cerr just gets redirected to /dev/null by the caller - perhaps revisit
that decision?



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/26090/#comment95122>

    Why the change in log message, it does't make sense now? e.g., "The launcher for updating
container abc123 1"



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/26090/#comment95128>

    You modify the argument but also return the modified version. Make this const, then create
a copy in the function that you modify and return?



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/26090/#comment95123>

    "launch the launcher" is confusing. Can you re-word to something like "Failed to run command
to obtain..."



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/26090/#comment95124>

    Ditto, using launcher is confusing.



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/26090/#comment95125>

    ditto



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/26090/#comment95129>

    ditto


- Ian Downes


On Sept. 26, 2014, 5:34 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26090/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 5:34 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: mesos-1808
>     https://issues.apache.org/jira/browse/mesos-1808
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto be45494 
>   src/slave/containerizer/isolators/network/helper.cpp 6cbcb33 
>   src/slave/containerizer/isolators/network/port_mapping.hpp b624c4d 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 2766a00 
> 
> Diff: https://reviews.apache.org/r/26090/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message