mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cody Maloney" <c...@mesosphere.io>
Subject Re: Review Request 26100: Switch [stout] to using compiler intrinsics for unreachable, exit, and abort
Date Mon, 29 Sep 2014 17:22:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26100/
-----------------------------------------------------------

(Updated Sept. 29, 2014, 5:22 p.m.)


Review request for mesos, Ben Mahler and Dominic Hamon.


Changes
-------

Reduce to just the stout changes, as was intended.


Bugs: MESOS-1744
    https://issues.apache.org/jira/browse/MESOS-1744


Repository: mesos-git


Description
-------

Use compiler intrinsics for unreachable, exit, and abort
Makes the functions not need to pretend to return something while
still silencing the compiler warnings.

Replaces 25191 (I originally authored the patch, but Patrick was managing it for various reasons).
Incorporates the fix suggested by Ben Mahler. Fixes Dominic's build issue.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp f20feeac11f62785cd00511e1d4fc53baf752123

  3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp aaccbb4dbe8e2e771ed2198ab2232bbd5361f319

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 23628a4686203e3edd0d8bb6e57060cdf4aec745

  3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 5607896d489f4c5eced9c0aa77b190a955644580

  3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp 3568886ba983fad85e74d2a3ade0178997fcb55c


Diff: https://reviews.apache.org/r/26100/diff/


Testing
-------

make distcheck of this and the two associated patches using gcc


Thanks,

Cody Maloney


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message