mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 26103: Switch [mesos] to using compiler intrinsics for unreachable, exit, and abort
Date Fri, 26 Sep 2014 21:55:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26103/#review54742
-----------------------------------------------------------

Ship it!


Ship It!

- Dominic Hamon


On Sept. 26, 2014, 2:40 p.m., Cody Maloney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26103/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 2:40 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Dominic Hamon.
> 
> 
> Bugs: MESOS-1744
>     https://issues.apache.org/jira/browse/MESOS-1744
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Use compiler intrinsics for unreachable, exit, and abort
> Makes the functions not need to pretend to return something while
> still silencing the compiler warnings.
> 
> Replaces 25193
> 
> 
> Diffs
> -----
> 
>   src/log/leveldb.cpp 2967a1f7c6ff35c1280299c3d73aaa951ab89273 
>   src/log/network.hpp 7d6b59292c2f5cf9cb99045fcd0960cab67c7e51 
>   src/slave/containerizer/mesos/launch.cpp 981938149060fb16467df4c65d729f76583b8c0f 
>   src/tests/routing_tests.cpp 35bdf8f69b9ffebc1cae2b8f42c5fea169f23a97 
>   src/zookeeper/zookeeper.cpp 72c9fc36648ea225876c06cd7559cb0ffc95dfe7 
> 
> Diff: https://reviews.apache.org/r/26103/diff/
> 
> 
> Testing
> -------
> 
> make distcheck of this and the two associated patches using gcc
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message