mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 26100: Switch [stout] to using compiler intrinsics for unreachable, exit, and abort
Date Fri, 26 Sep 2014 21:54:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26100/#review54740
-----------------------------------------------------------

Ship it!


Ship It!


3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp
<https://reviews.apache.org/r/26100/#comment95035>

    these should be ok not inline as they're member methods.


- Dominic Hamon


On Sept. 26, 2014, 2:40 p.m., Cody Maloney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26100/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 2:40 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Dominic Hamon.
> 
> 
> Bugs: MESOS-1744
>     https://issues.apache.org/jira/browse/MESOS-1744
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Use compiler intrinsics for unreachable, exit, and abort
> Makes the functions not need to pretend to return something while
> still silencing the compiler warnings.
> 
> Replaces 25191 (I originally authored the patch, but Patrick was managing it for various
reasons). Incorporates the fix suggested by Ben Mahler. Fixes Dominic's build issue.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp f20feeac11f62785cd00511e1d4fc53baf752123

>   3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp aaccbb4dbe8e2e771ed2198ab2232bbd5361f319

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 23628a4686203e3edd0d8bb6e57060cdf4aec745

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 5607896d489f4c5eced9c0aa77b190a955644580

>   3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp 3568886ba983fad85e74d2a3ade0178997fcb55c

>   3rdparty/libprocess/src/process.cpp e46e6b136c594cad5fa00fb7a5ff268e352753ce 
>   3rdparty/libprocess/src/subprocess.cpp 5b92200050df071190ab2d36abff050a7a077442 
>   src/log/leveldb.cpp 2967a1f7c6ff35c1280299c3d73aaa951ab89273 
>   src/log/network.hpp 7d6b59292c2f5cf9cb99045fcd0960cab67c7e51 
>   src/slave/containerizer/mesos/launch.cpp 981938149060fb16467df4c65d729f76583b8c0f 
>   src/tests/routing_tests.cpp 35bdf8f69b9ffebc1cae2b8f42c5fea169f23a97 
>   src/zookeeper/zookeeper.cpp 72c9fc36648ea225876c06cd7559cb0ffc95dfe7 
> 
> Diff: https://reviews.apache.org/r/26100/diff/
> 
> 
> Testing
> -------
> 
> make distcheck of this and the two associated patches using gcc
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message