mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <a...@mesosphere.io>
Subject Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.
Date Fri, 26 Sep 2014 12:09:13 GMT


> On Sept. 25, 2014, 11:48 p.m., Michael Park wrote:
> > Could you do a drive-by fix here to make the [web](http://mesos.apache.org/documentation/latest/mesos-c++-style-guide/)
version display the C++11 whitelist correctly? It seems to display correctly on [github](https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.md).
> > 
> > On the web version I'm seeing:
> > 
> > ## Empty Lines
> > 
> > * 1 blank line at the end of the file.
> > * Elements outside classes (classes, structs, global functions, etc.) should be
spaced apart by 2 blank lines.
> > * Elements inside classes (member variables and functions) should not be spaced
apart by more than 1 blank line.
> > 
> > ## C++11
> > We still support older compilers. The whitelist of supported C++11 features is:
* Static assertions. * Multiple right angle brackets. * Type inference (`auto` and `decltype`).
* Rvalue references. * Variadic templates.

I see the same. Hope adding a newline will help. Thanks for bringing it up!


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25622/#review54629
-----------------------------------------------------------


On Sept. 25, 2014, 11:47 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25622/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2014, 11:47 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1793
>     https://issues.apache.org/jira/browse/MESOS-1793
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Explicitly prohibit the use of namespace aliases. The discussion about using namespace
aliases took place in [the other review](https://reviews.apache.org/r/25434/#comment91754).
The majority agreed not to introduce them in code.
> 
> Give examples of preferable way of using auto.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 59a39df 
> 
> Diff: https://reviews.apache.org/r/25622/diff/
> 
> 
> Testing
> -------
> 
> Documentation change, no `make check` needed.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message