mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 25191: Switch [stout] to using compiler intrinsics for unreachable, exit, and abort
Date Thu, 25 Sep 2014 21:26:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25191/#review54600
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp
<https://reviews.apache.org/r/25191/#comment94787>

    make check fails here for me (on clang) because this is not marked inline.
    
    same for the other methods in this diff.


- Dominic Hamon


On Sept. 25, 2014, 12:34 p.m., Patrick Reilly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25191/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2014, 12:34 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Dominic Hamon.
> 
> 
> Bugs: MESOS-1744
>     https://issues.apache.org/jira/browse/MESOS-1744
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Use compiler intrinsics for unreachable, exit, and abort
> Makes the functions not need to pretend to return something while
> still silencing the compiler warnings.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp f20feea 
>   3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp aaccbb4 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5bbf829 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 5607896 
>   3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp 3568886 
> 
> Diff: https://reviews.apache.org/r/25191/diff/
> 
> 
> Testing
> -------
> 
> Make check runs.
> 
> 
> Thanks,
> 
> Patrick Reilly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message