mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).
Date Wed, 24 Sep 2014 21:27:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25861/#review54307
-----------------------------------------------------------



src/slave/containerizer/mesos/containerizer.hpp
<https://reviews.apache.org/r/25861/#comment94397>

    Fix the indent please!



src/slave/containerizer/mesos/containerizer.hpp
<https://reviews.apache.org/r/25861/#comment94582>

    Indent.



src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/25861/#comment94584>

    Can you add some context about why we need to do the prepare sequentially (instead of
concurrently)?



src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/25861/#comment94583>

    Can we use auto now? I am a little against using auto for now since we don't have a style
guide that tells us where should or should not use auto.



src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/25861/#comment94597>

    Ditto for 'auto'



src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/25861/#comment94602>

    Hum, the semantics changed a little bit here:
    
    Previously, isolator->cleanup will be called anyway even if some isolators' cleanup
fails.
    
    Now, if one isolator->cleanup fails, the rest of the cleanups will not be called.
    
    Are you sure this is safe? Will that cause resource leaks?


- Jie Yu


On Sept. 22, 2014, 6:45 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25861/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2014, 6:45 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Change from doing in parallel and collect()ing to serial according to the vector of isolators
(reversed order for cleanup).
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp bf246ca649ca4a461cebf1aee6908a2d58eec362

>   src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c

> 
> Diff: https://reviews.apache.org/r/25861/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message