mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chi Zhang" <chzhc...@gmail.com>
Subject Re: Review Request 25948: Routing: added support to obtain basic socket diagnosis information, using the inet-diag module from libnl3.
Date Tue, 23 Sep 2014 23:18:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25948/
-----------------------------------------------------------

(Updated Sept. 23, 2014, 11:18 p.m.)


Review request for mesos, Jie Yu and Cong Wang.


Changes
-------

the members in struct Info can't be defined as const because:

http://stackoverflow.com/questions/634662/non-static-const-member-cant-use-default-assignment-operator


Bugs: Mesos-1808
    https://issues.apache.org/jira/browse/Mesos-1808


Repository: mesos-git


Description
-------

see Summary.


Diffs (updated)
-----

  configure.ac da61c29 
  src/Makefile.am 9b973e5 
  src/linux/routing/diagnosis/diagnosis.hpp PRE-CREATION 
  src/linux/routing/diagnosis/diagnosis.cpp PRE-CREATION 
  src/linux/routing/internal.hpp dca0dc5 
  src/tests/routing_tests.cpp 10730ad 

Diff: https://reviews.apache.org/r/25948/diff/


Testing
-------

added a test to use the code path. 


Thanks,

Chi Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message