mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 25848: Introducing mesos modules.
Date Mon, 22 Sep 2014 09:33:17 GMT


> On Sept. 19, 2014, 7:39 p.m., Niklas Nielsen wrote:
> > src/module/manager.hpp, line 88
> > <https://reviews.apache.org/r/25848/diff/1/?file=697028#file697028line88>
> >
> >     Can we find some ABI documentation that supports this claim and maybe throw
in a reference?

Added a TODO for now.


> On Sept. 19, 2014, 7:39 p.m., Niklas Nielsen wrote:
> > src/module/manager.hpp, lines 117-118
> > <https://reviews.apache.org/r/25848/diff/1/?file=697028#file697028line117>
> >
> >     Access to those need to be guarded, right? Or do you explicitally call out that
the module manager isn't thread safe?

Added a TODO for now.


> On Sept. 19, 2014, 7:39 p.m., Niklas Nielsen wrote:
> > src/slave/flags.hpp, line 328
> > <https://reviews.apache.org/r/25848/diff/1/?file=697030#file697030line328>
> >
> >     Let's tie the modules in after the core patch has landed. Also, we need to it
for both masters and slaves (alongside starting to wire up module loading for isolators, authenticators,
...)
> >     
> >     TL;DR Let's review the src/slave/flags.hpp and src/slave/main.cpp changes (with
a master equivalent) in a dependent patch.
> >     
> >     In the new review, please expand the help text and throw in some examples. You
can put in the expected format as you listed in the module manager header.

Removed this code for now.  Will create a separate patch and address these concerns there.


> On Sept. 19, 2014, 7:39 p.m., Niklas Nielsen wrote:
> > src/tests/module_tests.cpp, line 123
> > <https://reviews.apache.org/r/25848/diff/1/?file=697033#file697033line123>
> >
> >     Where are we going to capture the negative tests? Wrong library versions, trying
to load non-mesos modules libraries (libc.so for example)?

Added a TODO for now.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review54043
-----------------------------------------------------------


On Sept. 22, 2014, 5:30 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25848/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2014, 5:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, and Timothy
St. Clair.
> 
> 
> Bugs: MESOS-1384
>     https://issues.apache.org/jira/browse/MESOS-1384
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Adding a first class primitive, abstraction and process for dynamic library writing and
loading can make it easier to extend inner workings of Mesos. Making it possible to have dynamic
loadable resource allocators, isolators, containerizes, authenticators and much more.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module.hpp PRE-CREATION 
>   src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 
>   src/examples/test_module.hpp PRE-CREATION 
>   src/examples/test_module_impl.cpp PRE-CREATION 
>   src/module/manager.hpp PRE-CREATION 
>   src/module/manager.cpp PRE-CREATION 
>   src/tests/module_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25848/diff/
> 
> 
> Testing
> -------
> 
> Ran make check with added tests for verifying library/module loading and simple version
check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message