mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.
Date Sat, 20 Sep 2014 00:07:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25798/#review54055
-----------------------------------------------------------

Ship it!


LGTM (awaiting dependent patch to land) - Ben, any concerns/issues?

- Niklas Nielsen


On Sept. 19, 2014, 12:01 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25798/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 12:01 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Follow up from 25079.
> Reduces compile time overall by ~1/3rd. 
> Move implementation of libprocess help into cpp file.
> Use strings::join to refactor macro expansion that was injecting lots of overhead even
when the expanded functions were not used.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am edbe54b 
>   3rdparty/libprocess/include/process/help.hpp 4333b5b 
>   3rdparty/libprocess/src/help.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25798/diff/
> 
> 
> Testing
> -------
> 
> make check on 3rdparty
> support/mesos-style.py
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message