-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25798/#review53889
-----------------------------------------------------------
3rdparty/libprocess/include/process/help.hpp
<https://reviews.apache.org/r/25798/#comment93745>
&& sticks to T, so 'T&&' (consistent with current style - know that we
have been discussing how it actually binds).
Here and below.
3rdparty/libprocess/include/process/help.hpp
<https://reviews.apache.org/r/25798/#comment93746>
Can we rename 'ss' to something more descriptive? Here and below.
3rdparty/libprocess/include/process/help.hpp
<https://reviews.apache.org/r/25798/#comment93747>
std::endl?
3rdparty/libprocess/src/help.cpp
<https://reviews.apache.org/r/25798/#comment93748>
Unused?
3rdparty/libprocess/src/help.cpp
<https://reviews.apache.org/r/25798/#comment93752>
'using std::string' and trim rest of file? :-)
3rdparty/libprocess/src/help.cpp
<https://reviews.apache.org/r/25798/#comment93741>
Is this a copy of the help text in the header? If so, let's delete it here.
3rdparty/libprocess/src/help.cpp
<https://reviews.apache.org/r/25798/#comment93743>
Two new lines between implementing functions here and rest of file.
3rdparty/libprocess/src/help.cpp
<https://reviews.apache.org/r/25798/#comment93749>
Mind indenting per http://mesos.apache.org/documentation/latest/mesos-c++-style-guide/
3rdparty/libprocess/src/help.cpp
<https://reviews.apache.org/r/25798/#comment93751>
The indentation in the return here (and below) seems to be off.
3rdparty/libprocess/src/help.cpp
<https://reviews.apache.org/r/25798/#comment93750>
The indentation seem a bit off here.
- Niklas Nielsen
On Sept. 18, 2014, 3:53 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25798/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2014, 3:53 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Follow up from 25079.
> Reduces compile time overall by ~1/3rd.
> Move implementation of libprocess help into cpp file.
> Use strings::join to refactor macro expansion that was injecting lots of overhead even
when the expanded functions were not used.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am edbe54b
> 3rdparty/libprocess/include/process/help.hpp 4333b5b
> 3rdparty/libprocess/src/help.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25798/diff/
>
>
> Testing
> -------
>
> make check on 3rdparty
> support/mesos-style.py
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
|