mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 25789: Variadic strings join for c++11 and above
Date Thu, 18 Sep 2014 23:10:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
-----------------------------------------------------------

(Updated Sept. 18, 2014, 11:10 p.m.)


Review request for mesos and Benjamin Hindman.


Changes
-------

Dealt with mixed use between (const char *) and (std::string) in a single join() call. Accompanying
unit test.


Repository: mesos-git


Description
-------

Add Variadic strings join for c++11 and above.
There is a second version of the variadic join which takes a reference to a stringstream as
a parameter. This is handy when strings::join is just a part of a larger string manipulation.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd 
  3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 

Diff: https://reviews.apache.org/r/25789/diff/


Testing
-------

Ran make check for stout. Added test cases for join as these were missing.


Thanks,

Joris Van Remoortere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message