mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy St. Clair" <tstcl...@redhat.com>
Subject Re: Review Request 25695: Update to enable systemd control of mesos services
Date Thu, 18 Sep 2014 19:36:48 GMT


> On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote:
> > This more looks like a hack. What if people compile mesos on a machine without systemd
and run it on a machine with systemd? I am in favor of a dynamic solution. Have you considered
the suggestion I gave last time?

I didn't want to interfear with existing behavior if possible, and I know that it's going
to have to shift again once the DBUS interface becomes the only method to interface with cgroups.
 I was hoping in the future to wrap some of the isolation behind a Module such that in the
future we could easily "proof of concept" the DBUS changes.  While this patch serves to "just
get it working" for EL7 and Fedora.  

re: "What if people compile mesos on a machine without systemd and run it on a machine with
systemd?" - That would only exist in a case where folks compiled on say EL5 and tried to run
those binaries on EL7.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25695/#review53837
-----------------------------------------------------------


On Sept. 16, 2014, 6:19 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25695/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 6:19 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1195
>     https://issues.apache.org/jira/browse/MESOS-1195
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This update enables support for systemd co-managed cgroup controllers
> 
> 
> Diffs
> -----
> 
>   configure.ac c4b4391 
>   src/linux/cgroups.cpp 5093b4c 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad47 
> 
> Diff: https://reviews.apache.org/r/25695/diff/
> 
> 
> Testing
> -------
> 
> systemctl start mesos-master mesos-slave
> several runs of 'mesos execute' to verify creation and cleanup.
> systemctl stop mesos-master mesos-slave
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message