mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy St. Clair" <tstcl...@redhat.com>
Subject Re: Review Request 25695: Update to enable systemd control of mesos services
Date Thu, 18 Sep 2014 18:37:38 GMT


> On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote:
> > src/linux/cgroups.cpp, lines 1778-1792
> > <https://reviews.apache.org/r/25695/diff/2/?file=690745#file690745line1778>
> >
> >     So you never cleanup other cgroups (like memory) on machines with systemd?

Correct, *never* unmount, this is handled by systemd.


> On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote:
> > configure.ac, lines 470-472
> > <https://reviews.apache.org/r/25695/diff/2/?file=690744#file690744line470>
> >
> >     Is there a way to eliminate `PKG_CHECK_MODULES`? I think last time, some people
have issues when bootstrapping if `PKG_CHECK_MODULES` is used.

Could we determine what the root cause is before we through it out?  I would like to know
why it is an issue.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25695/#review53837
-----------------------------------------------------------


On Sept. 16, 2014, 6:19 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25695/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 6:19 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1195
>     https://issues.apache.org/jira/browse/MESOS-1195
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This update enables support for systemd co-managed cgroup controllers
> 
> 
> Diffs
> -----
> 
>   configure.ac c4b4391 
>   src/linux/cgroups.cpp 5093b4c 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad47 
> 
> Diff: https://reviews.apache.org/r/25695/diff/
> 
> 
> Testing
> -------
> 
> systemctl start mesos-master mesos-slave
> several runs of 'mesos execute' to verify creation and cleanup.
> systemctl stop mesos-master mesos-slave
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message