mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 25756: post-reviews.py: added --no-color to git log.
Date Wed, 17 Sep 2014 23:35:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25756/
-----------------------------------------------------------

(Updated Sept. 17, 2014, 7:35 p.m.)


Review request for mesos.


Changes
-------

Updated problem description


Repository: mesos-git


Description (updated)
-------

For setups that have colored output for git log.

For example, the command "git --no-pager log --pretty=oneline --reverse master..HEAD" should
generate output similiar to the following:
```
fa7e46cfc228e9f80e08d7c28a978d561fbba5a7 post-reviews.py: added --no-color to git log. - For
setups that have colored output for git log.
```

However, in a setup where git emits colored output, the raw output would look like the following:
```
^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m post-reviews.py: added --no-color to
git log. - For setups that have colored output for git log.
```

The parser in post-review.py then picks '`^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m`'
as the sha and crashes.

The fix is to add '--no-color' to force git to never emit colored ouput.


Diffs
-----

  support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e 

Diff: https://reviews.apache.org/r/25756/diff/


Testing
-------

Created this review request using the updated script.


Thanks,

Kapil Arya


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message