mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kamil Domanski" <kdoman...@kdemail.net>
Subject Re: Review Request 25735: change const pass-by-value to const reference in stout
Date Wed, 17 Sep 2014 14:25:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25735/
-----------------------------------------------------------

(Updated Sept. 17, 2014, 4:25 p.m.)


Review request for mesos.


Bugs: MESOS-1805
    https://issues.apache.org/jira/browse/MESOS-1805


Repository: mesos-git


Description
-------

os::shell and an overload of strings::internal::fmt in stout pass a const string parameter
by copy instead of reference. This patch fixes that.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 58ab742 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 

Diff: https://reviews.apache.org/r/25735/diff/


Testing
-------

cd 3rdparty/libprocess/3rdparty/ && make check


Thanks,

Kamil Domanski


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message