mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 25523: Add Docker pull to docker abstraction
Date Wed, 17 Sep 2014 14:19:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25523/#review53675
-----------------------------------------------------------

Ship it!



src/tests/docker_tests.cpp
<https://reviews.apache.org/r/25523/#comment93472>

    Please move '{' to newline.



src/tests/docker_tests.cpp
<https://reviews.apache.org/r/25523/#comment93473>

    Why isn't all of this just:
    
    future.discard();
    
    AWAIT_DISCARDED(future);
    
    The extra promise->set(Nothing()) is not testing anything new here. Perhaps the important
thing for me to say is that just because we're calling 'future.discard()' does not mean that
the future will get discarded, hence AWAIT_DISCARDED(future) is sufficient.


Minor cleanup/simplification in the test then lets get this committed!

- Benjamin Hindman


On Sept. 17, 2014, 8:23 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25523/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 8:23 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/25523
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp e7adedb93272209231a3a9aefecfd6ccc7802ff5 
>   src/docker/docker.cpp a8becb8290c8982c64546c7f72d4bfe89f7ca5a1 
>   src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a 
>   src/tests/docker_tests.cpp e6c228a27a9c3cbf2fa0cc58843989c49fa90456 
> 
> Diff: https://reviews.apache.org/r/25523/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message