mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 25597: Added a version checker class to stout.
Date Mon, 15 Sep 2014 22:26:15 GMT


> On Sept. 15, 2014, 2:46 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, lines 86-89
> > <https://reviews.apache.org/r/25597/diff/3/?file=688423#file688423line86>
> >
> >     Can you remove all of the _ suffixes for these members? If you look through
our codebase, we don't use this pattern.
> >     
> >     Looks like we don't need to store the 'version' (what you called 'str_' here),
since we can re-construct it using major/minor/patch.

The public methods are named major(), minor(), and patch() and that's why the _ suffix for
the data members. What is the proper way to handle this situation?  Of course, one possibility
is to rename major/minor/patch methods with get{Major,Minor,Patch}(). Any suggestions?


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/#review53370
-----------------------------------------------------------


On Sept. 15, 2014, 6:22 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25597/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2014, 6:22 p.m.)
> 
> 
> Review request for mesos, Adam B and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Currently there is no facility in Mesos for checking compatibility of various Mesos components
that could have been built at different times with potentially different Mesos versions. 
This requirement is especially important for doing various compatibility checks between Mesos
and Mesos modules (WIP).
> 
> - Features major, minor, and patch numbers.
> - Convenience functions for comparing two versions.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am db9766d70adb9076946cd2b467c55636fe5f7235 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am b6464de53c3873ecd0b62a08ca9aac530043ffb9

>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 6fa5b741bdd7f089ba93bf6fea43b9f39f8f0edb

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5bbf829b3fa5d09a92e1d64c52c1fc7eed73fc91

>   3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25597/diff/
> 
> 
> Testing
> -------
> 
> Added a stout test and ran make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message