mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 25549: Basic filesystem isolator for Linux.
Date Mon, 15 Sep 2014 22:05:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25549/#review53404
-----------------------------------------------------------



src/slave/slave.cpp
<https://reviews.apache.org/r/25549/#comment93061>

    This only adds the default container Info for the executor, but I think it makes sense
to add it on the TaskInfo when just CommandInfo is defined as well. It's not related to this
patch but since you added the default containerInfo already I think it will be great to wire
that as well.



src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/25549/#comment93073>

    One more space between tests



src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/25549/#comment93072>

    end with period.


- Timothy Chen


On Sept. 15, 2014, 8:01 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25549/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2014, 8:01 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1586
>     https://issues.apache.org/jira/browse/MESOS-1586
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Does not report usage or enforce quota but can create 'private' directories for each
container which mask parts of the shared host filesystem.
> 
> This review replaces https://reviews.apache.org/r/24178/ because of some file renaming.
I addressed all comments from earlier reviews.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto dea51f94d130c131421c43e7fd774ceb8941f501 
>   src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 
>   src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 
>   src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee 
>   src/slave/containerizer/isolators/filesystem/shared.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION 
>   src/slave/containerizer/linux_launcher.cpp d5ef1d6aa762cf81a3e8384552d97fe95b9cbd95

>   src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c

>   src/slave/flags.hpp 21e00212bc402674eaea73b44b3f91df477a7213 
>   src/slave/slave.cpp 1b3dc7370a2441e4159aa5ee552b64ca5e511e96 
>   src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 
>   src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 
> 
> Diff: https://reviews.apache.org/r/25549/diff/
> 
> 
> Testing
> -------
> 
> make check # added a test
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message