mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cody Maloney" <c...@mesosphere.io>
Subject Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart
Date Sat, 13 Sep 2014 00:33:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
-----------------------------------------------------------

(Updated Sept. 13, 2014, 12:33 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Patrick Reilly, and Vinod Kone.


Changes
-------

Address Dominic's comments


Bugs: MESOS-1739
    https://issues.apache.org/jira/browse/MESOS-1739


Repository: mesos-git


Description
-------

Allows attributes and resources to be set to a superset of what they were previously on a
slave restart.

Incorporates all comments from: 
https://issues.apache.org/jira/browse/MESOS-1739
and the former review request:
https://reviews.apache.org/r/25111/


Diffs (updated)
-----

  src/Makefile.am 9b973e5 
  src/common/attributes.hpp 0a043d5 
  src/common/attributes.cpp aab114e 
  src/common/slaveinfo_utils.hpp PRE-CREATION 
  src/common/slaveinfo_utils.cpp PRE-CREATION 
  src/master/master.hpp b492600 
  src/master/master.cpp d5db24e 
  src/slave/slave.cpp 1b3dc73 
  src/tests/attributes_tests.cpp 240a8ca 
  src/tests/slave_tests.cpp 69be28f 

Diff: https://reviews.apache.org/r/25525/diff/


Testing
-------

make check on localhost


Thanks,

Cody Maloney


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message