mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Review Request 25567: Hold on to unacknowledged terminal tasks in the Master.
Date Fri, 12 Sep 2014 02:01:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25567/
-----------------------------------------------------------

Review request for mesos, Niklas Nielsen and Vinod Kone.


Bugs: MESOS-1410
    https://issues.apache.org/jira/browse/MESOS-1410


Repository: mesos-git


Description
-------

This is the MESOS-1410 which fixes MESOS-1389.

The idea here is that the master needs to hold on to those tasks that are terminal, but have
yet to be acknowledged by the scheduler. Otherwise, reconciliation requests could lead to
TASK_LOST updates **before** a framework receives a terminal TASK_FINISHED/TASK_FAILED/etc
update for the task.

Now the master needs to:
(1) Remove tasks when an acknowledgement arrives.
(2) Recover resources when the task becomes terminal.
(3) Omit resources for terminal tasks in the http statistics.


Diffs
-----

  src/master/master.hpp b4926001178ebb00b34b0b7e03f491d4a800afc2 
  src/master/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 

Diff: https://reviews.apache.org/r/25567/diff/


Testing
-------

make check

Added new tests in https://reviews.apache.org/r/25568/


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message