mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Review Request 25566: Minor cleanups to the Master code.
Date Fri, 12 Sep 2014 02:01:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25566/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos-git


Description
-------

(1) Updated the Slave struct to avoid counting resources. Rather, when asked, compute resources
based on the tasks. This makes it easier to do the resource accounting in https://reviews.apache.org/r/25567/
where we hold on to terminal tasks.

(2) Cleaned up the task removal logging, to be inside removeTask(Task*).

(3) Consistently use utils::copy instead of keys() / values() when a copy is required to iterate
correctly, to make it more explicit to the reader.


Diffs
-----

  src/master/http.cpp 6dd11fe5297ea68331b5e9f23a6d8590edecedc4 
  src/master/master.hpp b4926001178ebb00b34b0b7e03f491d4a800afc2 
  src/master/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 

Diff: https://reviews.apache.org/r/25566/diff/


Testing
-------

no functional change

make check


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message