mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 25511: Pulled the log line in ZooKeeperTestServer::shutdownNetwork() to above the shutdown call.
Date Thu, 11 Sep 2014 05:00:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25511/#review52999
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Sept. 10, 2014, 6:02 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25511/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2014, 6:02 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> - When debugging zookeeper related tests it's often more useful to know when the tests
is about to shut down the ZK server to reason about the order of events. Otherwise client
disconnections are often logged before this "shutdown" line and can be confusing.
> 
> 
> Diffs
> -----
> 
>   src/tests/zookeeper_test_server.cpp a8c9b1cd8a546abdeb4d89a8fe9ebc3b3d577665 
> 
> Diff: https://reviews.apache.org/r/25511/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message