mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy St. Clair" <tstcl...@redhat.com>
Subject Re: Review Request 25508: Fix git clean -xdf skipping leveldb
Date Wed, 10 Sep 2014 17:33:44 GMT


> On Sept. 10, 2014, 5:26 p.m., Vinod Kone wrote:
> > 3rdparty/Makefile.am, line 84
> > <https://reviews.apache.org/r/25508/diff/1/?file=684613#file684613line84>
> >
> >     didn't realize that the leveldb we bundle has git files in it! isn't the proper
fix here to bundle a proper 'dist'ribution of leveldb instead of its git tree?

You're probably right.  I didn't want to rethunk a tarball though.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25508/#review52894
-----------------------------------------------------------


On Sept. 10, 2014, 4:30 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25508/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2014, 4:30 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1764
>     https://issues.apache.org/jira/browse/MESOS-1764
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Very minor change to allow git clean -xdf to remove the leveldb directory
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 7cf0c88 
> 
> Diff: https://reviews.apache.org/r/25508/diff/
> 
> 
> Testing
> -------
> 
> make check 
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message