mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 25487: Increased session timeouts for ZooKeeper related tests.
Date Wed, 10 Sep 2014 16:24:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25487/#review52884
-----------------------------------------------------------



src/tests/zookeeper.cpp
<https://reviews.apache.org/r/25487/#comment92073>

    Seconds(10) ?


- Dominic Hamon


On Sept. 9, 2014, 10:57 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25487/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 10:57 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1676
>     https://issues.apache.org/jira/browse/MESOS-1676
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> - On slower machines sometimes the zookeeper c client times out where we aren't expecting
because either the test server or the client is too slow to respond. Increasing this value
helps mitigate the problem.
> - The effect of "server->shutdownNetwork()" is immediate so this won't prolong the
tests so long as they don't wait for session expiration without clock advances, which I have
checked and there is none.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_contender_detector_tests.cpp 9ac59aa446a132e734238e0e55801117c4ef31b4

>   src/tests/zookeeper.cpp e45f956e1486e952a4efeb123e15568518fb53fe 
> 
> Diff: https://reviews.apache.org/r/25487/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message