mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 24776: Add docker containerizer destroy tests
Date Tue, 09 Sep 2014 18:15:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review52758
-----------------------------------------------------------


Why did you need to mock DockerContainerizerProcess in order to write these tests? Couldn't
you have just used the existing MockDockerContainerizer?


src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/24776/#comment91796>

    Please move '=' back on previous line.



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/24776/#comment91798>

    Looks like wierd indentation here.


- Benjamin Hindman


On Aug. 16, 2014, 10:23 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2014, 10:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add docker containerizer destroy tests
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp fe5b29167811d4ac2fe29070c70a04f84093a6ff 
>   src/tests/docker_containerizer_tests.cpp 8654f9c787bd207f6a7b821651e0c083bea9dc8a 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message