mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <a...@mesosphere.io>
Subject Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.
Date Tue, 09 Sep 2014 16:42:46 GMT


> On Sept. 9, 2014, 4:21 p.m., Timothy Chen wrote:
> > src/launcher/executor.cpp, line 682
> > <https://reviews.apache.org/r/25434/diff/2/?file=683946#file683946line682>
> >
> >     I'm not sure I'm really following the logic, I know the levels but I don't know
why there is the divide by 2/3 on each level?

Since we have nested grace periods, we would like to guarantee that the parent one is greater
than the child one, otherwise the child can be killed by the parent though the shutdown was
successful.


> On Sept. 9, 2014, 4:21 p.m., Timothy Chen wrote:
> > src/launcher/executor.cpp, line 664
> > <https://reviews.apache.org/r/25434/diff/2/?file=683946#file683946line664>
> >
> >     I'm not sure we've all agreed to start using C++11 yet?
> 
> Niklas Nielsen wrote:
>     Good catch - no auto's yet.

My understanding is that we already can: https://mail-archives.apache.org/mod_mbox/mesos-dev/201408.mbox/%3CCA+A2mTsGU2CfcdROo-wPgnd95jy6XQcaNNg6n6MJqYhdnRjB-g@mail.gmail.com%3E


> On Sept. 9, 2014, 4:21 p.m., Timothy Chen wrote:
> > src/exec/exec.cpp, line 738
> > <https://reviews.apache.org/r/25434/diff/2/?file=683945#file683945line738>
> >
> >     Why divide by 2 here? It seems like no matter what you're shrinking the timeout?

I'm not shrinking the slave's timeout (the one the user set in flags), rather I set the timeout
in Executor to a smaller value. This value is determined according to the slave's timeout.


> On Sept. 9, 2014, 4:21 p.m., Timothy Chen wrote:
> > src/exec/exec.cpp, line 736
> > <https://reviews.apache.org/r/25434/diff/2/?file=683945#file683945line736>
> >
> >     let's log when you shrink the timeout.

Makes sense, will do it.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25434/#review52729
-----------------------------------------------------------


On Sept. 9, 2014, 12:54 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25434/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 12:54 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1571
>     https://issues.apache.org/jira/browse/MESOS-1571
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The configurable slave's executor_shutdown_grace_period flag is propagated to Executor
and CommandExecutor through an environment variable. Shutdown timeout in Executor and signal
escalation timeout in CommandExecutor are now dependent on this flag. Each nested timeout
is somewhat shorter than the parent one.
> 
> 
> Diffs
> -----
> 
>   src/exec/exec.cpp 36d1778 
>   src/launcher/executor.cpp 12ac14b 
>   src/slave/constants.hpp 9030871 
>   src/slave/constants.cpp e1da5c0 
>   src/slave/containerizer/containerizer.hpp 8a66412 
>   src/slave/containerizer/containerizer.cpp 0254679 
>   src/slave/containerizer/docker.cpp 0febbac 
>   src/slave/containerizer/external_containerizer.cpp efbc68f 
>   src/slave/containerizer/mesos/containerizer.cpp 9d08329 
>   src/slave/flags.hpp 21e0021 
>   src/tests/containerizer.cpp a17e1e0 
> 
> Diff: https://reviews.apache.org/r/25434/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X 10.9.4; Ubuntu 14.04 amd64)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message