mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 22066: Added timeout to rescind unused offers
Date Thu, 04 Sep 2014 21:09:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22066/
-----------------------------------------------------------

(Updated Sept. 4, 2014, 5:09 p.m.)


Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Timothy Chen.


Changes
-------

More updates to reflect Ben's suggestions.


Bugs: mesos-186
    https://issues.apache.org/jira/browse/mesos-186


Repository: mesos-git


Description
-------

A timer is associated with each newly created offer.
The offer is rescinded on timeout.
The timer is disarmed on a launchTask or decline.

This is continuation of Tim's patch: https://reviews.apache.org/r/22796/.  Revision two represents
the latest patch from Tim. I have tried to address the comments/concerns from that request
into the third revision.


Diffs (updated)
-----

  src/master/flags.hpp 5e9ecb5 
  src/master/master.hpp c9f989a 
  src/master/master.cpp 2508b38 
  src/tests/master_tests.cpp eaa1675 

Diff: https://reviews.apache.org/r/22066/diff/


Testing
-------

Added one more test after Tim's patch to test offer is not rescinded once it has been declined.

make check


Thanks,

Kapil Arya


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message