mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 25274: Update the Mesos C++ Style Guide.
Date Wed, 03 Sep 2014 15:48:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25274/#review52178
-----------------------------------------------------------


Patch looks great!

Reviews applied: [25274]

All tests passed.

- Mesos ReviewBot


On Sept. 3, 2014, 12:44 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25274/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 12:44 a.m.)
> 
> 
> Review request for mesos, Adam B, Cody Maloney, Dominic Hamon, Niklas Nielsen, and Timothy
Chen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> While introducing ClangFormat, I found that there were hidden styles in the codebase
that weren't mentioned in the Mesos C++ Style Guide.
> This patch updates the Mesos C++ Style Guide with these hidden style guidelines.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md a5f8df8737733500fb5385564dd46f01b6f91181 
> 
> Diff: https://reviews.apache.org/r/25274/diff/
> 
> 
> Testing
> -------
> 
> Used ClangFormat to determine that these style guidelines are consistent across the codebase.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message