mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 25184: Delete framework data in TaskStatus to avoid OOM
Date Mon, 01 Sep 2014 04:08:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25184/#review51963
-----------------------------------------------------------



src/master/master.cpp
<https://reviews.apache.org/r/25184/#comment90679>

    I don't think we want to put spark specific comments, we can describe a scenario where
we can OOM.
    Also we generally don't use block comments, we use single line comments style in Mesos.
    
    Otherwise I think the changes makes sense. You will want to run all the master unit tests
just to make sure.


- Timothy Chen


On Aug. 30, 2014, 10:12 a.m., Chengwei Yang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25184/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2014, 10:12 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-1746
>     https://issues.apache.org/jira/browse/MESOS-1746
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> There was a bug found that Spark use TaskStatus.data to transfer computed
> result and mesos-master RES memory keeps increasing fast and finally will be
> killed by OOM killer.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 2508b38e86b8399886bffcbaca8ec11c731363d8 
> 
> Diff: https://reviews.apache.org/r/25184/diff/
> 
> 
> Testing
> -------
> 
> tested with spark
> 
> 
> Thanks,
> 
> Chengwei Yang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message