Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DB20B11831 for ; Wed, 13 Aug 2014 18:11:42 +0000 (UTC) Received: (qmail 53048 invoked by uid 500); 13 Aug 2014 18:11:42 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 52986 invoked by uid 500); 13 Aug 2014 18:11:42 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 52973 invoked by uid 99); 13 Aug 2014 18:11:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Aug 2014 18:11:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1CA891D9D8B; Wed, 13 Aug 2014 18:11:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2173483765456568873==" MIME-Version: 1.0 Subject: Re: Review Request 24658: Updated equality check for CommandInfo. From: "Jie Yu" To: "Vinod Kone" Cc: "Jie Yu" , "mesos" Date: Wed, 13 Aug 2014 18:11:42 -0000 Message-ID: <20140813181142.27785.16731@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/24658/ X-Sender: "Jie Yu" References: <20140813181055.1262.23984@reviews.apache.org> In-Reply-To: <20140813181055.1262.23984@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos-git --===============2173483765456568873== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Aug. 13, 2014, 6:10 p.m., Vinod Kone wrote: > > src/common/type_utils.cpp, lines 76-86 > > > > > > Hmm. I think the order is important for argv right? > > > > e.g., ./foo argv1 argv2 is not the same as ./foo argv2 argv1. Good catch! - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24658/#review50478 ----------------------------------------------------------- On Aug. 13, 2014, 5:49 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24658/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 5:49 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee > > Diff: https://reviews.apache.org/r/24658/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > > --===============2173483765456568873==--