Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E1C1611E06 for ; Fri, 8 Aug 2014 00:09:18 +0000 (UTC) Received: (qmail 28065 invoked by uid 500); 8 Aug 2014 00:09:18 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 28004 invoked by uid 500); 8 Aug 2014 00:09:18 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 27985 invoked by uid 99); 8 Aug 2014 00:09:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Aug 2014 00:09:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 23BC21DB520; Fri, 8 Aug 2014 00:09:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7857873338257084307==" MIME-Version: 1.0 Subject: Review Request 24485: Allowed flags to load from a configure file as defaults. From: "Jie Yu" To: "Benjamin Hindman" , "Ben Mahler" , "Vinod Kone" , "Dominic Hamon" Cc: "Jie Yu" , "mesos" Date: Fri, 08 Aug 2014 00:09:04 -0000 Message-ID: <20140808000904.1587.41658@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/24485/ X-Sender: "Jie Yu" Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos-git --===============7857873338257084307== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24485/ ----------------------------------------------------------- Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Vinod Kone. Bugs: MESOS-1651 https://issues.apache.org/jira/browse/MESOS-1651 Repository: mesos-git Description ------- See ticket for details. When parsing flags, users now can specify a file to be used as defaults. The command line arguments will override the defaults specified in the configure file. The file is a JSON object: { "flag1" : "string", "flag2" : true, "flag3" : 10, "flag4" : { "a" : 1, "b" : 2} .. } Diffs ----- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 112dcb1 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8 src/tests/main.cpp 442be51 Diff: https://reviews.apache.org/r/24485/diff/ Testing ------- make check Thanks, Jie Yu --===============7857873338257084307==--