Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72E7911E68 for ; Wed, 6 Aug 2014 01:11:46 +0000 (UTC) Received: (qmail 45734 invoked by uid 500); 6 Aug 2014 01:11:46 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 45670 invoked by uid 500); 6 Aug 2014 01:11:46 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 45647 invoked by uid 99); 6 Aug 2014 01:11:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Aug 2014 01:11:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1C2A01DB0BF; Wed, 6 Aug 2014 01:11:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8122412919584967400==" MIME-Version: 1.0 Subject: Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes. From: "Yifan Gu" To: "Vinod Kone" , "Ian Downes" Cc: "Dominic Hamon" , "Adam B" , "Yifan Gu" , "Mesos ReviewBot" , "Ben Mahler" , "mesos" Date: Wed, 06 Aug 2014 01:11:32 -0000 Message-ID: <20140806011132.1587.44446@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Yifan Gu" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/22313/ X-Sender: "Yifan Gu" References: <20140806003724.1587.7745@reviews.apache.org> In-Reply-To: <20140806003724.1587.7745@reviews.apache.org> Reply-To: "Yifan Gu" X-ReviewRequest-Repository: mesos-git --===============8122412919584967400== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/ ----------------------------------------------------------- (Updated Aug. 6, 2014, 1:11 a.m.) Review request for mesos, Ian Downes and Vinod Kone. Bugs: MESOS-886 https://issues.apache.org/jira/browse/MESOS-886 Repository: mesos-git Description ------- Added __runTask() to wait for the completion of containerizer->update() and check the result before sending RunTaskMessage. Diffs (updated) ----- src/slave/slave.hpp c12cd0a src/slave/slave.cpp c56cac8 src/tests/slave_tests.cpp 3a7fee6 Diff: https://reviews.apache.org/r/22313/diff/ Testing (updated) ------- SlaveTest.WillNotLaunchTaskBeforeContainerizerUpdate SlaveTest.WillNotLaunchTaskIfFrameworkIsRemoved SlaveTest.LaunchTaskAfterContainerizerUpdate ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter=*LaunchTask* successful times > 2000 make check File Attachments ---------------- framework will exit https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff log https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log Thanks, Yifan Gu --===============8122412919584967400==--