Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A9FCF11BB9 for ; Tue, 5 Aug 2014 23:49:22 +0000 (UTC) Received: (qmail 31124 invoked by uid 500); 5 Aug 2014 23:49:22 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 31059 invoked by uid 500); 5 Aug 2014 23:49:22 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 31041 invoked by uid 99); 5 Aug 2014 23:49:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Aug 2014 23:49:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 354F91DB0B5; Tue, 5 Aug 2014 23:49:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3542603560549074534==" MIME-Version: 1.0 Subject: Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes. From: "Yifan Gu" To: "Vinod Kone" , "Ian Downes" Cc: "Dominic Hamon" , "Adam B" , "Yifan Gu" , "Mesos ReviewBot" , "Ben Mahler" , "mesos" Date: Tue, 05 Aug 2014 23:49:08 -0000 Message-ID: <20140805234908.1586.86192@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Yifan Gu" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/22313/ X-Sender: "Yifan Gu" References: <20140729210518.18793.45751@reviews.apache.org> In-Reply-To: <20140729210518.18793.45751@reviews.apache.org> Reply-To: "Yifan Gu" X-ReviewRequest-Repository: mesos-git --===============3542603560549074534== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/ ----------------------------------------------------------- (Updated Aug. 5, 2014, 11:49 p.m.) Review request for mesos, Ian Downes and Vinod Kone. Bugs: MESOS-886 https://issues.apache.org/jira/browse/MESOS-886 Repository: mesos-git Description ------- Added __runTask() to wait for the completion of containerizer->update() and check the result before sending RunTaskMessage. Diffs (updated) ----- src/slave/slave.hpp c12cd0a src/slave/slave.cpp ef921e1 src/tests/slave_tests.cpp 432d8a2 Diff: https://reviews.apache.org/r/22313/diff/ Testing ------- SlaveTest, CancelTaskIfContainerizerFails Which tests that if the containerizer->update() return a Failure, the task won't be launched and the scheduler will get TASK_LOST. make check File Attachments ---------------- framework will exit https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff log https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log Thanks, Yifan Gu --===============3542603560549074534==--