Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9ECC3116F5 for ; Tue, 5 Aug 2014 21:43:53 +0000 (UTC) Received: (qmail 8877 invoked by uid 500); 5 Aug 2014 21:43:53 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 8809 invoked by uid 500); 5 Aug 2014 21:43:53 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 8755 invoked by uid 99); 5 Aug 2014 21:43:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Aug 2014 21:43:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 60EC11DB082; Tue, 5 Aug 2014 21:43:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2223849159794866411==" MIME-Version: 1.0 Subject: Re: Review Request 24339: Killed MASTER_PING_TIMEOUT for fixing MESOS-1673. From: "Ben Mahler" To: "Ben Mahler" Cc: "Jie Yu" , "mesos" Date: Tue, 05 Aug 2014 21:43:39 -0000 Message-ID: <20140805214339.1586.98443@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/24339/ X-Sender: "Ben Mahler" References: <20140805214327.1587.42693@reviews.apache.org> In-Reply-To: <20140805214327.1587.42693@reviews.apache.org> Reply-To: "Ben Mahler" X-ReviewRequest-Repository: mesos-git --===============2223849159794866411== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Aug. 5, 2014, 9:43 p.m., Ben Mahler wrote: > > Ship It! Same TODO in master's constants? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24339/#review49645 ----------------------------------------------------------- On Aug. 5, 2014, 9:33 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24339/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 9:33 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1673 > https://issues.apache.org/jira/browse/MESOS-1673 > > > Repository: mesos-git > > > Description > ------- > > See summary and ticket. > > > Diffs > ----- > > src/slave/constants.hpp bc16fe5 > src/slave/constants.cpp f00300d > src/slave/slave.cpp ef921e1 > src/tests/slave_tests.cpp 432d8a2 > > Diff: https://reviews.apache.org/r/24339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > > --===============2223849159794866411==--