Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1C01D11E53 for ; Fri, 1 Aug 2014 21:14:14 +0000 (UTC) Received: (qmail 89532 invoked by uid 500); 1 Aug 2014 21:14:14 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 89463 invoked by uid 500); 1 Aug 2014 21:14:13 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 89448 invoked by uid 99); 1 Aug 2014 21:14:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Aug 2014 21:14:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ED72B1D9E29; Fri, 1 Aug 2014 21:13:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2241185874644123188==" MIME-Version: 1.0 Subject: Re: Review Request 24178: Basic filesystem isolator for Linux. From: "Mesos ReviewBot" To: "Ben Mahler" , "Jie Yu" Cc: "Mesos ReviewBot" , "mesos" , "Ian Downes" Date: Fri, 01 Aug 2014 21:13:59 -0000 Message-ID: <20140801211359.18793.54761@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/24178/ X-Sender: "Mesos ReviewBot" References: <20140801060833.18793.98898@reviews.apache.org> In-Reply-To: <20140801060833.18793.98898@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos-git --===============2241185874644123188== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24178/#review49383 ----------------------------------------------------------- Patch looks great! Reviews applied: [24177, 24178] All tests passed. - Mesos ReviewBot On Aug. 1, 2014, 6:08 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24178/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 6:08 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Bugs: MESOS-1586 > https://issues.apache.org/jira/browse/MESOS-1586 > > > Repository: mesos-git > > > Description > ------- > > Does not report usage or enforce quota but can create 'private' directories for each container which mask parts of the root filesystem. > > > Diffs > ----- > > src/Makefile.am b660d912c92594ef679b71caf508134f20511dae > src/slave/containerizer/isolators/filesystem.hpp PRE-CREATION > src/slave/containerizer/isolators/filesystem.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.cpp f3cc813c64e9298f43c9691de9d51ba29c3a8e91 > src/slave/containerizer/mesos/containerizer.cpp 2c394e2c8702166266f5d20ff005abb218da8a6c > src/slave/flags.hpp 146c4011eb6a64dbb03555cece1c5303338ae240 > src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 > > Diff: https://reviews.apache.org/r/24178/diff/ > > > Testing > ------- > > # added two tests for the FilesystemIsolator > make check > > > Thanks, > > Ian Downes > > --===============2241185874644123188==--