mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Reilly" <patrick.rei...@gmail.com>
Subject Re: Review Request 25111: Added the concept of dynamically configurable slave attributes
Date Thu, 28 Aug 2014 16:55:54 GMT


> On Aug. 28, 2014, 8:37 a.m., Adam B wrote:
> > Great start! I've got several style nits, and some thoughts about extending beyond
supersets.
> > - How do you plan to test this? Have you tried just restarting a checkpointed slave
process with new resources/attributes? I think you would run into a "Incompatible slave info
detected" error.
> > - We should start a conversation on the JIRA about how people would want to use
this, what protobuf/cli/etc. API to define, and what to do about updates that are not supersets.

Hey [~adam-mesos] I've added a comment https://issues.apache.org/jira/browse/MESOS-1739?focusedCommentId=14113960&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14113960
to the JIRA ticket.


- Patrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25111/#review51753
-----------------------------------------------------------


On Aug. 28, 2014, 4:42 p.m., Patrick Reilly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25111/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2014, 4:42 p.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1739
>     https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add basic stub for dynamic slave attributes
> 
> 
> Diffs
> -----
> 
>   src/common/attributes.hpp 0a043d5 
>   src/common/attributes.cpp aab114e 
>   src/master/master.hpp c9f989a 
>   src/master/master.cpp 2508b38 
>   src/slave/slave.hpp 9d4607e 
>   src/slave/slave.cpp 5c76dd1 
> 
> Diff: https://reviews.apache.org/r/25111/diff/
> 
> 
> Testing
> -------
> 
> This is currently a work in progress, (WIP)
> 
> 
> Thanks,
> 
> Patrick Reilly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message