mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Reilly" <patrick.rei...@gmail.com>
Subject Re: Review Request 25079: Replaced macro expansion with variadic template
Date Wed, 27 Aug 2014 19:57:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25079/
-----------------------------------------------------------

(Updated Aug. 27, 2014, 7:57 p.m.)


Review request for mesos, Adam B and Benjamin Hindman.


Changes
-------

Fixing compatibility by adding guard against C++11 features with ifdef.


Bugs: MESOS-1734
    https://issues.apache.org/jira/browse/MESOS-1734


Repository: mesos-git


Description
-------

Reduce compile time:  - replacing a macro expansion with a variadic template - moving implementation
from help.hpp to help.cpp


Diffs (updated)
-----

  3rdparty/libprocess/Makefile.am edbe54b 
  3rdparty/libprocess/include/process/help.hpp 4333b5b 
  3rdparty/libprocess/src/help.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/25079/diff/


Testing
-------

Ran "make check".


Thanks,

Patrick Reilly


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message