mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 25030: Replaced PKG_CHECK_MODULES with AC_CHECKs in configure.ac.
Date Wed, 27 Aug 2014 18:50:36 GMT


> On Aug. 26, 2014, 12:38 a.m., Timothy St. Clair wrote:
> > configure.ac, line 407
> > <https://reviews.apache.org/r/25030/diff/1/?file=668368#file668368line407>
> >
> >     Can we just do the compile check?

I will add a TODO for using AX_CXX_CHECK_LIB once we resolve the legal issue. For now, I'll
just use the old patch and check for _init.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25030/#review51468
-----------------------------------------------------------


On Aug. 25, 2014, 11:29 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25030/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 11:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1727
>     https://issues.apache.org/jira/browse/MESOS-1727
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary and ticket. Some people suggested that PKG_CHECK_MODULES is considered harmful.
> 
> 
> Diffs
> -----
> 
>   configure.ac 996c21d52a731744058bba76040a8aa454dd8b5c 
>   m4/ax_cxx_check_lib.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25030/diff/
> 
> 
> Testing
> -------
> 
> ./bootstrap.sh
> ./configure
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message