mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 25079: Replaced macro expansion with variadic template
Date Tue, 26 Aug 2014 21:58:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25079/#review51595
-----------------------------------------------------------


It was done using macro expansion because variadic templates require C++11.

We're not yet able to assume C++11: https://issues.apache.org/jira/browse/MESOS-750

- Ben Mahler


On Aug. 26, 2014, 9:44 p.m., Patrick Reilly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25079/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2014, 9:44 p.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1734
>     https://issues.apache.org/jira/browse/MESOS-1734
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Reduce compile time:  - replacing a macro expansion with a variadic template - moving
implementation from help.hpp to help.cpp
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am edbe54b 
>   3rdparty/libprocess/include/process/help.hpp 4333b5b 
>   3rdparty/libprocess/src/help.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25079/diff/
> 
> 
> Testing
> -------
> 
> Ran "make check".
> 
> 
> Thanks,
> 
> Patrick Reilly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message