mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 23710: Add line comments end punctuation style rule
Date Tue, 26 Aug 2014 06:54:48 GMT


> On Aug. 25, 2014, 1:01 a.m., Adam B wrote:
> > support/cpplint.py, line 1540
> > <https://reviews.apache.org/r/23710/diff/2/?file=664933#file664933line1540>
> >
> >     Why 'continue' on first and last line? If you skip this early, you'll never
set "previous_line = line" to catch punctuation errors in comments on these lines?
> 
> Timothy Chen wrote:
>     I need to skip the first and last line because ProcessFileData in cpplint.py adds
a extra line in the beginning and in the end for line numbers.

Fair enough. Can you put in a comment explaining this and the dummy comment?


> On Aug. 25, 2014, 1:01 a.m., Adam B wrote:
> > support/cpplint.py, lines 1550-1552
> > <https://reviews.apache.org/r/23710/diff/2/?file=664933#file664933line1550>
> >
> >     s/i/i-1/?
> 
> Timothy Chen wrote:
>     ah, I think it should be i+1? since it's 0 based index.
> 
> Timothy Chen wrote:
>     Actually it should be i because of the padding done.

What testing was done on this code? 'make check' hardly seems relevant.
Did you verify that these style errors print the correct line number?


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23710/#review51382
-----------------------------------------------------------


On Aug. 25, 2014, 5:12 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23710/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 5:12 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/23710
> 
> 
> Diffs
> -----
> 
>   support/cpplint.patch 1dd69a03044c0c17ca4ee555c6c9d27ea043d4f0 
>   support/cpplint.py bfd3390002a680b07aa3fcf785279ad19625294b 
>   support/mesos-style.py d24cb11adc06bc0ebaaa206301616c8b597f09e8 
> 
> Diff: https://reviews.apache.org/r/23710/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message