mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 24766: Set ownership of stdout/stderr and container directory properly.
Date Sat, 16 Aug 2014 16:25:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24766/#review50823
-----------------------------------------------------------



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24766/#comment88685>

    Do you want to chown for fetched stuff as well?



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24766/#comment88683>

    You can get rid of the last argument 'true' because the default is 'true'



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24766/#comment88684>

    Ditto


- Jie Yu


On Aug. 16, 2014, 4:36 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24766/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2014, 4:36 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp ced0f9247ccb8d1419e464f5c0730b2796ece8e7 
> 
> Diff: https://reviews.apache.org/r/24766/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message