mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 24667: Added a user doc for framework rate limiting.
Date Wed, 13 Aug 2014 23:44:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24667/#review50526
-----------------------------------------------------------



docs/framework-rate-limiting.md
<https://reviews.apache.org/r/24667/#comment88388>

    s/the this/this/
    
    s/that it crashes/causing the master to OOM/



docs/framework-rate-limiting.md
<https://reviews.apache.org/r/24667/#comment88389>

    not sure I understand the statement in brackets. can you rephrase maybe?



docs/framework-rate-limiting.md
<https://reviews.apache.org/r/24667/#comment88390>

    s/turns/terms/



docs/framework-rate-limiting.md
<https://reviews.apache.org/r/24667/#comment88391>

    what do you mean by "nature of the frameworks"? do you mean "messages generated by the
frameworks"?



docs/framework-rate-limiting.md
<https://reviews.apache.org/r/24667/#comment88392>

    by "its messages" you mean master's or frameworks'? i guess the latter? i'm still a bit
unclear on what the recommendation is here. can you expand on the comment?


- Vinod Kone


On Aug. 13, 2014, 9:10 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24667/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 9:10 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1683
>     https://issues.apache.org/jira/browse/MESOS-1683
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/framework-rate-limiting.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24667/diff/
> 
> 
> Testing
> -------
> 
> Rendered version: https://gist.github.com/xujyan/d2bdd2052fac489fb1a9
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message