mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy St. Clair" <tstcl...@redhat.com>
Subject Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf
Date Wed, 13 Aug 2014 19:24:49 GMT


> On Aug. 11, 2014, 9:16 p.m., Vinod Kone wrote:
> > src/examples/python/test-executor.in, lines 24-30
> > <https://reviews.apache.org/r/23086/diff/4/?file=657922#file657922line24>
> >
> >     Here and in other example python scripts below, do you want to pass PROTOBUF_EGG
from configure.ac, similar to what you did with PROTOBUF_JAR? I think that would be more cleaner?
> >     
> >

So I've added a detection for the google.protobuf python module, but it doesn't install via
prefix, it's a separate step.  I've verified by checking the rpm & deb packages.  

So we'll have to verify via PYTHONPATH.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50231
-----------------------------------------------------------


On Aug. 11, 2014, 7:11 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 7:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
>     https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/Makefile.am 39af036 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
>   src/python/native/ext_modules.py.in 477e63d 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message