mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 24516: Expose pending tasks during reconciliation.
Date Wed, 13 Aug 2014 18:53:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24516/
-----------------------------------------------------------

(Updated Aug. 13, 2014, 6:53 p.m.)


Review request for mesos, Niklas Nielsen and Vinod Kone.


Changes
-------

Updated per vinod's review.


Bugs: MESOS-1620
    https://issues.apache.org/jira/browse/MESOS-1620


Repository: mesos-git


Description
-------

We were not surfacing tasks that are pending validation / authorization.

These are now surfaced as staging tasks


Diffs (updated)
-----

  src/master/master.cpp a8cf9ba07b041a770416ee70a0cff9ef51e0a844 
  src/tests/master_authorization_tests.cpp f0f064808d8bf36a2a756bc907c477dd6440636c 
  src/tests/reconciliation_tests.cpp 3c4d7ed886333f0ccc1460178b9e06e7e38246c9 

Diff: https://reviews.apache.org/r/24516/diff/


Testing
-------

Updated the existing test.

I also removed the MasterAuthorizationTest.ReconcileTask test because it was redundant with
ReconciliationTest.PendingTask.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message